<html>
<head><meta charset="utf-8"><title>Triage this week · t-compiler/performance · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/index.html">t-compiler/performance</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html">Triage this week</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="207796717"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/207796717" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#207796717">(Aug 23 2020 at 23:35)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> <span class="user-mention" data-user-id="118594">@ecstatic-morse</span> I'm not sure if I'll be able to continue doing rustc triage, because I need to work out the state of things w.r.t. Rust contributions and my job at Mozilla. Are either of you able to do it?</p>



<a name="207796727"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/207796727" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> njn <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#207796727">(Aug 23 2020 at 23:35)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> you mentioned using a calendar from the compiler team to plan and track who is doing triage. Any progress there? What is involved with setting that up?</p>



<a name="207796791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/207796791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#207796791">(Aug 23 2020 at 23:37)</a>:</h4>
<p>I can do it for the next few weeks unless Mark wants to take one.</p>



<a name="207800961"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/207800961" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#207800961">(Aug 24 2020 at 01:36)</a>:</h4>
<p>I have no particular desire to do so but happy to take over as needed, just give me a shout.</p>



<a name="207800970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/207800970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#207800970">(Aug 24 2020 at 01:37)</a>:</h4>
<p>I still need to ping Niko about calendar, will try to do so this week.</p>



<a name="208581512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208581512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208581512">(Aug 31 2020 at 16:25)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I'm planning to do triage again this week at around Tue ~02:00 UTC. Any updates on a calendar?</p>



<a name="208581604"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208581604" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208581604">(Aug 31 2020 at 16:26)</a>:</h4>
<p>oh, right, forgot to make a note here. The compiler team calendar now has a triage event</p>



<a name="208581711"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208581711" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208581711">(Aug 31 2020 at 16:26)</a>:</h4>
<p>That said, I'm not sure if its the best fit, maybe just pre-creating triage files with empty contents would be better when assigning oneself a week</p>



<a name="208581992"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208581992" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208581992">(Aug 31 2020 at 16:28)</a>:</h4>
<p><span class="user-mention" data-user-id="118594">@ecstatic-morse</span> I guess -- I think I can invite you to the calendar event if you have a google account so you can edit it to when you plan to do triage (and stick your name in the description)</p>



<a name="208582073"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208582073" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208582073">(Aug 31 2020 at 16:28)</a>:</h4>
<p>but I'm not feeling too great about the gcal design</p>



<a name="208582223"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208582223" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208582223">(Aug 31 2020 at 16:29)</a>:</h4>
<p>It's my username with no dash @gmail.com, but I also think PRs on the <code>rustc-perf</code> repo would be fine.</p>



<a name="208582405"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208582405" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208582405">(Aug 31 2020 at 16:30)</a>:</h4>
<p>Let's go with PRs for now</p>



<a name="208582590"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/208582590" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#208582590">(Aug 31 2020 at 16:31)</a>:</h4>
<p>Invited you to the event though</p>



<a name="209430487"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/209430487" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#209430487">(Sep 08 2020 at 19:10)</a>:</h4>
<p>Had a power outage last night/this morning. Should be able to finish triage this afternoon.</p>



<a name="209432636"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/209432636" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#209432636">(Sep 08 2020 at 19:27)</a>:</h4>
<p>Sounds good! Let me know when you get tired of doing it and we can switch.</p>



<a name="209846375"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/209846375" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#209846375">(Sep 11 2020 at 23:20)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> could you take over triage next week? Things are pretty chaotic in Oregon RN.</p>



<a name="209846978"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/209846978" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#209846978">(Sep 11 2020 at 23:30)</a>:</h4>
<p>Will do</p>



<a name="209847002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/209847002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#209847002">(Sep 11 2020 at 23:30)</a>:</h4>
<p>Hope you're staying healthy and safe!</p>



<a name="210133710"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210133710" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210133710">(Sep 15 2020 at 14:05)</a>:</h4>
<p>okay, kicking off triage</p>



<a name="210137072"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210137072" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210137072">(Sep 15 2020 at 14:30)</a>:</h4>
<p>done <a href="https://github.com/rust-lang/rustc-perf/blob/master/triage/2020-09-15.md">https://github.com/rust-lang/rustc-perf/blob/master/triage/2020-09-15.md</a></p>



<a name="210156943"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210156943" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210156943">(Sep 15 2020 at 16:57)</a>:</h4>
<p>The <a href="https://perf.rust-lang.org/index.html?start=35fc8359868e65a0970094f648ba87fce634e8c7&amp;end=a53f449516f23486d2dfd4e5685d4e869e8591d9&amp;absolute=false&amp;stat=instructions%3Au">"commit range"</a> link was broken. I left a PR.</p>
<p>Also, looking at the graph for the commit range, I was mildly surprised not to see <a href="https://perf.rust-lang.org/compare.html?start=97eb606e4b2becd17d46a67d87169f52b210e67c&amp;end=a1894e4afe1a39f718cc27232a5a2f0d02b501f6&amp;stat=instructions:u">https://perf.rust-lang.org/compare.html?start=97eb606e4b2becd17d46a67d87169f52b210e67c&amp;end=a1894e4afe1a39f718cc27232a5a2f0d02b501f6&amp;stat=instructions:u</a>. I would guess that it's a small regression to runtime hashbrown performance after the 0.9 upgrade that shows up mostly in docs and incremental builds (full, patched and unchanged).</p>



<a name="210157456"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210157456" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210157456">(Sep 15 2020 at 17:00)</a>:</h4>
<p>Maybe it would help to have rust-timer add a <code>A-compile-time</code>, the way it adds rollup=never currently? That way it would be easier to find PRs affecting perf</p>



<a name="210157512"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210157512" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210157512">(Sep 15 2020 at 17:00)</a>:</h4>
<p>(side note, I think it's hilarious that it adds rollup=never by calling another bot <span aria-label="laughing" class="emoji emoji-1f606" role="img" title="laughing">:laughing:</span> )</p>



<a name="210158226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210158226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210158226">(Sep 15 2020 at 17:05)</a>:</h4>
<p>I'm going to give automating this a try some night this week. I wanna make some progress on  <a href="https://github.com/rust-lang/rust/issues/76618">#76618</a>  first.</p>



<a name="210158829"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210158829" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210158829">(Sep 15 2020 at 17:10)</a>:</h4>
<p><code>I-compiletime</code>? That's the marker for issues re: compiler slowness.</p>



<a name="210161999"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210161999" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210161999">(Sep 15 2020 at 17:34)</a>:</h4>
<p><span class="user-mention" data-user-id="118594">@ecstatic-morse</span> I skipped it because it looked doc-only</p>



<a name="210162135"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210162135" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210162135">(Sep 15 2020 at 17:35)</a>:</h4>
<p>I missed that the rollup contained <a href="https://github.com/rust-lang/rust/pull/76458">https://github.com/rust-lang/rust/pull/76458</a> which is actually a hashbrown bump not just adding a few methods</p>



<a name="210162479"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210162479" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Dylan MacKenzie (ecstatic-morse) <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210162479">(Sep 15 2020 at 17:38)</a>:</h4>
<p>Yeah, we should try to get people to mark hashbrown updates as rollup=never. They usually have a minor impact on perf runs.</p>



<a name="210163048"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/247081-t-compiler/performance/topic/Triage%20this%20week/near/210163048" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Jubilee <a href="https://rust-lang.github.io/zulip_archive/stream/247081-t-compiler/performance/topic/Triage.20this.20week.html#210163048">(Sep 15 2020 at 17:42)</a>:</h4>
<p>Also bots are just variadic function calls, so clearly it's the correct choice. :^)</p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>